Skip to content
Snippets Groups Projects
Commit 53a36e0a authored by Jan Kadlec's avatar Jan Kadlec
Browse files

fix: Do not commit changes to journal if there are none.

parent 1e92c51b
No related branches found
No related tags found
No related merge requests found
......@@ -1513,17 +1513,20 @@ static int zones_insert_zone(conf_zone_t *z, knot_zone_t **dst,
}
/* Commit transaction. */
ret = zones_store_changesets_commit(transaction);
if (ret != KNOT_EOK) {
log_zone_error("Failed to commit stored changesets: %s."
"\n", knot_strerror(ret));
// Cleanup old and new contents
xfrin_rollback_update(zone->contents,
&new_contents,
sec_chs->changes);
zones_free_merged_changesets(diff_chs, sec_chs);
rcu_read_unlock();
return ret;
if (transaction) {
ret = zones_store_changesets_commit(transaction);
if (ret != KNOT_EOK) {
log_zone_error("Failed to commit stored "
"changesets: %s."
"\n", knot_strerror(ret));
// Cleanup old and new contents
xfrin_rollback_update(zone->contents,
&new_contents,
sec_chs->changes);
zones_free_merged_changesets(diff_chs, sec_chs);
rcu_read_unlock();
return ret;
}
}
/* Switch zone contents. */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment