Skip to content

revert regex to match whole module name as module_id

Martin Matějek requested to merge fix-modules-id-reading into master

Previously we almost fixed reading numeric prefix of diagnostics module by striping the prefix. Unfortunately this fix works only one-way - (re)foris will read module names correctly, but won't be able to create diagnostics. Because it will call diagnostics script with wrong module names (without numeric prefix).

So we reverted back to passing full module name and it is up to (re)foris to handle nice presentation in UI, while supplying correct module names.

Note that:

  • test and mocks are in bad shape and need refactoring (#4), however this is not in scope of this MR

Closes: #2 (closed), turris/foris/foris-diagnostics-plugin#10 (closed)

Edited by Martin Matějek

Merge request reports