Mocked DEFAULT_PACKAGE_LISTS should be updated

Up to date mock should be here

It differs from what is generated in real-world conditions.

added Bug label

mentioned in issue foris-controller-data_collect-module#4 (moved)

marked this issue as related to foris-controller#118 (closed)

mentioned in merge request !7 (merged)

I made merge request, however i would like to try to patch on master if it does not breake anything.. Will reach you on messenger.

changed milestone to %foris-controller-sentinel-module: sentinel state indication

added Review label

assigned to @fhron

added Doing label and removed Review label

added Review label and removed Doing label

When applied, two tests in foris-controller/tests/blackbox/test_updater.py keep failing.

def test_update_package_lists_override_defaults(): # <- imagine fixturese here
         settings = {
        "package_lists": [
            {"name": "datacollect", "options": [{"name": "minipot", "enabled": False}]},
            {"name": "datacollect", "options": [{"name": "survey", "enabled": True}]},
        ]
    }
    defaults = {"datacollect": {"dynfw"}}
    # ...
def test_update_settings_disable_updater_keep_settings(): # <- imagine fixturese here
    # and so on

There are two options why this is like that

• data generated by me are not correct and test utility to mock the updater cannot handle that
• mocking utility is not correct

I am not able to find the reason.

Steps to reproduce

• checkout fresh master foris_controller and update setup.py tests_require with foris-controller-testtools branch fix-mock-updater-data

"foris-controller-testtools @ git+https://gitlab.nic.cz/turris/foris-controller/foris-controller-testtools.git@fix-mock-updater-data#egg=foris-controller-testtools",

Run tests

python setup.py pytest --addopts="--backend openwrt --backend mock tests/blackbox/test_updater.py --pdb -x"

Another observation:

• when tests are executed individually another errors occure

Disregard the above, i think i might understood what that test has to test, so i updated the data and it passes now.

assigned to @mmatejek and unassigned @fhron

assigned to @fhron and unassigned @mmatejek

closed via merge request !7 (merged)

mentioned in issue foris-controller-sentinel-module#12 (closed)