dns: crash on missing ipv6 config key in resolver config
If ipv6
config key is missing in resolver config, foris-controller will crash with following stack trace:
For example /etc/resolver/dns_servers/00_odvr-cznic.conf
:
name="00_odvr-cznic.conf"
description="CZ.NIC (TLS)"
enable_tls="1"
port="853"
ipv4="193.17.47.1 185.43.135.1"
# <-- missing ipv6 here
ca_file="/etc/ssl/certs/ca-certificates.crt"
hostname="odvr.nic.cz"
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/foris_controller/message_router.py", line 117, in process_message
File "/usr/lib/python3.7/site-packages/foris_controller/module_base.py", line 61, in perform_action
File "/usr/lib/python3.7/site-packages/foris_controller_modules/dns/__init__.py", line 36, in action_get_settings
File "/usr/lib/python3.7/site-packages/foris_controller/utils.py", line 111, in inner
File "/usr/lib/python3.7/site-packages/foris_controller_modules/dns/handlers/openwrt.py", line 42, in get_settings
File "/usr/lib/python3.7/site-packages/foris_controller_backends/dns/__init__.py", line 237, in get_settings
File "/usr/lib/python3.7/site-packages/foris_controller_backends/dns/__init__.py", line 213, in get_available_forwarders_short
File "/usr/lib/python3.7/site-packages/foris_controller_backends/dns/__init__.py", line 177, in get_available_forwarders
AttributeError: 'NoneType' object has no attribute 'group'
Internal error 'NoneType' object has no attribute 'group'('<class 'AttributeError'>')
No ipv6 addresses specified is fine though, there just need to be ipv6
config key.
name="00_odvr-cznic.conf"
description="CZ.NIC (TLS)"
enable_tls="1"
port="853"
ipv4="193.17.47.1 185.43.135.1"
ipv6="" # <-- present, but no addresses
ca_file="/etc/ssl/certs/ca-certificates.crt"
hostname="odvr.nic.cz"