lighttpd: update to upstream 1.4.71
lighttpd: update to upstream 1.4.71
includes meson build changes (again, taken from openwrt upstream)
reference: #474 (closed)
Merge request reports
Activity
@mvasilek please review, per #474 (comment 274971) by @jschlehofer
mentioned in issue #474 (closed)
assigned to @mvasilek
requested review from @mvasilek
changed milestone to %Turris OS 6.3.1
added 9 commits
-
82d91715...1529f5d6 - 7 commits from branch
turris/os:develop
- b50afb36 - lighttpd: update to upstream 1.4.69
- 699b55dc - lighttpd: remove lighttpd TLS defaults from config
-
82d91715...1529f5d6 - 7 commits from branch
- Resolved by Glenn Strauss
rebased to tip of 'develop' branch to keep merge request fresh.
- Resolved by Glenn Strauss
@mvasilek with TOS 6.3.0 out, TOS 6.3.1 is up next.
Please let me know if you have an questions about this merge request.
changed milestone to %Turris OS 6.3.2
changed milestone to %Turris OS 6.3.3
added 13 commits
-
699b55dc...191043f4 - 10 commits from branch
turris/os:develop
- ec72eb9a - lighttpd: update to upstream 1.4.69
- 7d2a2b36 - lighttpd: remove lighttpd TLS defaults from config
- daf245e5 - lighttpd: update to upstream 1.4.70
Toggle commit list-
699b55dc...191043f4 - 10 commits from branch
In the commit ec72eb9a the http:www-data was uncommented and now it matches fully with OpenWrt config (and closes #854 (closed))
This is great but potentially may cause some issues when a web-root is a directory is mounted as root. As far I see the
http:www-data
user and group are already exists in OpenWrt with group id 33. The lighttpd package doesn't create them. If yes, then it should be possible to mount with uid/gid. Mounting by a username is not supported as far I know. The init script has a lineuser_exists http || user_add http
so it should create a user but still not clear about the group.I checked myself and started the lighttpd as
http:www-data
. For a dav folder mounted from a disk with root and it works and files are created with a root user. The process is running as thehttp
and I'm confused why this happens. I checked groups of the http user withgroups http
and looks like it doesn't belongs to any. This is probably because the http user was created by the init script.Another one problem is that existing folders are owned by a root and on start we may get an error like:
/configfile.c opening errorlog '/var/log/lighttpd/error.log' failed: Permission denied
Overall from what I see the Turris lighttpd package now looks exactly same as in OpenWrt. Maybe I missed something? If yes then the custom lighttpd can be removed at all instead of the PR, right?
Turris OS overrides the lighttpd config in /etc/lighttpd/conf.d/90-turris.conf to intentionally run as root. Please check the git history of that file for more details. There is also a long history in #474 (closed).
@mvasilek please disregard most things posted by @stokito.
@stokito too often fails to verify his observations, often jumping to wildly incorrect conclusions. His post above is no exception to being wildly incorrect.
No, this merge request is not intended to do anything related to #854 (closed) and does not address #854 (closed). I referenced #474 (closed) in my post above, but did not mention #854 (closed). @stokito are you intelligent enough to figure out the significance of my referencing #474 (closed) but not referencing #854 (closed)? Yeah, that's because #854 (closed) is not in scope here.
@stokito PLEASE DO NOT POST FURTHER IN THIS MERGE REQUEST. You are NOT HELPING and are making incorrect statements which may further confuse the understaffed Turris software team.