Skip to content

Draft: foris-controller: update to version 2.1.2

Martin Matějek requested to merge hotfix/foris-controller-2.1.2 into master

Fixed:

  • wifi: backport fixes for reading HT modes; it is now possible to save wifi settings on Turris 1.x router or any router with DNXA-H1 wireless card

Please note that this is only fix release for TOS 5.3.x and the backported code is already present in foris-controller in TOS 6.0

How to test

  • any Turris router with wireless card DNXA-H1;
  • stable Turris OS 5.3.6

expected behavior before fix

root@modrak:/# foris-client-wrapper -m wifi -a get_settings | python -m json.tool
{
    "devices": [
        {
            "id": 0,
            "enabled": false,
            "SSID": "Turris",
            "channel": 36,
            "hidden": false,
            "hwmode": "11a",
            "htmode": "HT20",
            "password": "",
            "guest_wifi": {
                "enabled": false,
                "SSID": "Turris-guest",
                "password": ""
            },
            "available_bands": [
                {
                    "available_channels": [...],
                    "available_htmodes": [
                        "NOHT",
                        "HT20",
                        "HT40"
                    ],
                    "hwmode": "11g"
                },
                {
                    "available_channels": [...],
                    "available_htmodes": [
                        "NOHT" <-- only this
                    ],
                    "hwmode": "11a"
                }
            ]
        }
    ]
}

  • 802.11n - 20/40 MHz wide channels are not present in modes for 5 GHz band in reForis wifi page; only Disabled
  • Any update of wifi settings for 5 GHz band is never applied, although reForis shows success.
  • Update of settings for 2 GHz band works fine.

expected behaviour after fix

root@modrak:/# foris-client-wrapper -m wifi -a get_settings | python -m json.tool
{
    "devices": [
        {
            "id": 0,
            "enabled": false,
            "SSID": "Turris",
            "channel": 36,
            "hidden": false,
            "hwmode": "11a",
            "htmode": "HT20",
            "password": "",
            "guest_wifi": {
                "enabled": false,
                "SSID": "Turris-guest",
                "password": ""
            },
            "available_bands": [
                {
                    "available_channels": [...],
                    "hwmode": "11g",
                    "available_htmodes": [
                        "NOHT",
                        "HT20",
                        "HT40"
                    ]
                },
                {
                    "available_channels": [...],
                    "hwmode": "11a",
                    "available_htmodes": [
                        "NOHT", \
                        "HT20",  } all supported modes are here
                        "HT40"  /
                    ]
                }
            ]
        }
    ]
}
  • 802.11n - 20/40 MHz wide channels are present in modes for 5 GHz band in reForis wifi page
  • update of wifi settings in reForis for 5 GHz band now proceed successfully

Note

  • other wireless cards shipped with Turris routers should work fine before and after fix

cc: @jbetik

Edited by Martin Matějek

Merge request reports