Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • U updater
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 35
    • Issues 35
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Turris
  • updater
  • updater
  • Merge requests
  • !282

src/lib/lua/planner: reinstall package if more than version not match

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Karel Koci requested to merge package-signature into master Jun 23, 2020
  • Overview 3
  • Commits 2
  • Pipelines 4
  • Changes 4

This extends list of fields checked for reinstall to not only Version but also to Architecture, LinkSignature, Depends, Conflicts, Provides.

There are two reasons why we want to have these:

First reason applies on Architecture, Depends, Conflicts and Provides. Those trigger update to get package information in sync with repository. Updater runs planning against repository so this has no effect but in the end if someone forgets to bump package but modifies dependencies for example then we reinstall package anyway.

Second reason to reinstall package applies on LinkSignature and that is field inserted with hash generated from dynamic linker information collected for package. When this hash changes then link dependencies changed and even if version is same we have to reinstall such package as it most probably won't work with updated dependencies.

As a tinny bonus logs now contain info about version or any other field if the differ and that way info about the reason to reinstall given package.

This is tied to https://gitlab.labs.nic.cz/turris/turris-build/-/merge_requests/189

Fixes https://gitlab.labs.nic.cz/turris/turris-build/issues/146

Indirectly potentially fixes https://gitlab.labs.nic.cz/turris/turris-build/issues/154 and https://gitlab.labs.nic.cz/turris/turris-os-packages/issues/417.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: package-signature