Originally it's from another branch.

The complication is that we need to work with addresses and
just file-descriptors passed from some parent process.
The former approach lead to logical duplication of some steps;
now we add a step converting addresses to file-descriptors.
Thanks to that we always do bind() without touching libuv,
so the problem with forking disappears :-)

That was against docs.  Fortunately, nil is falsy.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

Only the first byte was being shown since 3ab77332.
I can't see at all why this part was changed;
the buffer is (and was) way overlong for this,
so writing one zero byte just after the end is OK.

Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

The layer functions are supposed to return the new state.
We've been lucky that errors are negative numbers and thus
they typically passed the (status & KR_STATE_FAIL) test.

Vladimír Čunát authored 6 years ago and Tomas Krizek committed 5 years ago

... for layers and props.  This breaks C module API+ABI.

It seemed weird to repeatedly call a function that returns a pointer
to a structure in which we find the function we want to actually call.
We've never used changing these functions AFAIK, and the target
functions could easily be written to change their behavior instead
(i.e. move the indirection *inside* the function).

When breaking this, I also removed these two (_layers and _props)
from the dynamic symbols (to be) exported from the C modules.
They always pointed to memory belonging inside the module,
and they seem quite sensible to be set up by the _init symbol instead.

It gets handy for debugging, especially when looking at dufferent
callback "instances".

It would be pointless anyway as it cannot provide more information.

As far as I understand the debug.sethook('call') descrption we are not
going to have any locals except function parameters so we can simplify
the code.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

"Unfortunately", for FFI-bound C functions there it doesn't hold that
missing parameters would be converted to nil/NULL.
Still, this function seems unlikely to have been used outside the repo.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

It caused crashes somewhere inside LuaJIT or the JIT-ed code.

This will allow modules like view etc. work in the same way with packets
received over HTTP.

First version which actually works with Firefox DoH in default
configuration.

Limitations:
- does not support HTTP GET method
- headers for HTTP cache are not generated
- error handling is largely missing
- no tests
- ACLs will not work, modules do not see source IP address of the HTTP
endpoint

This does not work with C functions etc. but it seems that we do not
expose them directly in Lua interface for users.

This makes it much easier to navigate in complex data structures.
AFAIK table_print is not used for anything except user interface so it
is not performance critical and we can re-sort table every time.

User-friendly error message is intentionally at the end so users,
typically looking at the last line in logs, can see immediatelly what
happened.

Previous version would add the TA and then print error message, which is
not expected.

Tomas Krizek authored 6 years ago and Petr Špaček committed 5 years ago

Since DNSSEC is now enabled by default and always loads the
keyfile_default specified during compilation, these options are
obsolete.

Use trust_anchors.add_file() in config file if you require this
functionality.

Tomas Krizek authored 6 years ago and Petr Špaček committed 5 years ago

+ tests

Exracting RFC 5011 to separate module was a good opportunity for
cleanup.

Previously a typo in keyfile path triggered re-bootstrap even if root TA
was already installed.