Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The logs can be triggered from policy actions, in per-request fashion:
- they're on LOG_DEBUG level but always sent, regardless of log config
- those messages will show double group tags: "[reqdbg][foo   ]"
  (but they lack proper meta-data - about location of the log's origin)
- reqdbg is *in addition* to normal logs, so the lines may be duplicated
  if that's how the logging was configured

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

It's special: always on and not shown in log_groups() output.

It's been quite a long fight to find how to best deal with such
a special case (from user perspective; code itself is easy).

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The result gets logged as a single multi-line message,
so let's not repeat any prefix on (some of) those in-the-middle lines.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Systemd docs say:
> Those arguments must contain valid journal entries including
> the variable name, e.g. "CODE_FILE=src/foo.c", [...]

I tried that passing all three strings empty (without variable name)
wouldn't result into the line getting logged; the suggested style does.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

I suspect it was me who broke the ordering here.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The former "default" dumping style isn't really used anywhere in Knot.
The only visible difference is that RRSIGs are now logged *without*
replacing their TTLs by the original non-decremented TTL values.
That can avoid some confusion when reading debug logs.
(Those original TTLs are still shown a bit further on each line.)

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Logging is not set up at this point; it wouldn't be shown unless
preceded by -v/--verbose.

various tiny changes

See merge request !1200

Code wouldn't be leaked.  We'd just send the branch name to GH servers.
Still, it' better to skip the step.

This is all that's missing in comparison to enum knot_rr_type.
For now I didn't remove types that aren't present there (anymore),
even though noone would miss them, most likely.

Also improve a few details.

../modules/dnstap/dnstap.c: In function 'dnstap_config':
../modules/dnstap/dnstap.c:410:29: warning: 'strndup' specified bound 4096 exceeds source size 17 [-Wstringop-overread]
  410 |                 sock_path = strndup(DEFAULT_SOCK_PATH, PATH_MAX);
      |                             ^
../modules/dnstap/dnstap.c:423:37: warning: 'strndup' specified bound 4096 exceeds source size 17 [-Wstringop-overread]
  423 |                         sock_path = strndup(DEFAULT_SOCK_PATH, PATH_MAX);
      |                                     ^

We don't need to restrict our built-in path defaults to PATH_MAX
characters, as they just can't be that long and it's not an issue if we
shoot over it anyway - opening such a file would only fail.

daemon/lua/meson.build: disable kres_gen_test on cross

See merge request !1198

I considered switching it to our usual 3-option combo,
but that way didn't really seem useful.

I didn't intend to use this mix of tabs and spaces for indentation.

fix build without doh2 support

See merge request !1197

release 5.4.0

See merge request !1196

daemon/http: ensure HTTP headers are freed

See merge request !1191

Ignored queries never call create_request() where ownership of headers
is taken care of. They need to be explicitly cleared instead, because
we're the owners of the pointer here.

Fine grained logging

See merge request !1181

- we've been using lua's formatting so far, so avoid changing that
- some lua values would be harder to format with the C style

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Our randomness utils have nothing to do with TLS, so let's use SYSTEM.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

* improve order
  - follow grouping of topics more closely (targets, groups, levels)
  - order kr_log_LEVEL by severity
* move unneeded <stdarg.h>
* improve doc-comments
  - some claims there were even wrong now
  - describe some log levels at kr_log_LEVEL

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Let's be consistent witk kr_log_name2level()
and even generally we tend to use negative numbers for errors.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

It's a non-standard feature of syslog.h and I don't think it's worth
the trouble.

We didn't really utilize it; someone would have to #define it,
and moreover we would get into problems if this wasn't being done
the same on all places including log.h.
Making the names adapt to the platform would also mean that
config files and docs wouldn't be portable.

Also make kr_log_level2name() return const.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- we don't need doubling the layer in this case,
  as the SD_JOURNAL_METADATA macro adds a layer already
- `TO_STR` was perhaps a too short name and could collide