Skip to content
Snippets Groups Projects
  1. Feb 15, 2017
  2. Jan 25, 2017
  3. Jan 24, 2017
  4. Jan 23, 2017
  5. Jan 20, 2017
  6. Jan 18, 2017
  7. Jan 17, 2017
  8. Jan 16, 2017
  9. Jan 13, 2017
  10. Jan 11, 2017
  11. Jan 10, 2017
  12. Jan 03, 2017
  13. Dec 27, 2016
  14. Dec 12, 2016
  15. Dec 09, 2016
  16. Dec 07, 2016
  17. Nov 08, 2016
    • Vladimír Čunát's avatar
      layer: refactor and better describe the API · cc47973e
      Vladimír Čunát authored
      - The API and ABI for modules changes slightly (details below).
        KR_MODULE_API is bumped to avoid loading incompatible code.
        We have bumped libkres ABIVER since the last release 1.1.1,
        so leaving that one intact.
      
      - Make KR_STATE_YIELD not reuse 0 value anymore.
        It's easy to e.g. return kr_ok() by mistake.
      - struct kr_layer_t:
        * ::mm was unused, uninitialized, etc.
        * Make ::state an int, as it was everywhere else.
        * void *data was ugly and always containing struct kr_request *
      - struct kr_layer_api:
        * Drop the void* parameter from ::begin, as it was only used
          for the request which is available as ctx->req anyway
          (formerly ctx->data).
        * Drop ::fail.  It wasn't even called.  Modules can watch for
          KR_STATE_FAIL in ::finish.
      - Document the apparent meaning of the layer interface, deduced mainly
        from the way it's used in the code.  Caveats:
        * enum knot_layer_state handling seems to assume that it holds exactly
          one of the possibilities at a time.  The cookie module does NOT
          follow that (intentionally), apparently depending on the exact
          implementation of the handling at that moment.  It feels fragile.
        * I was unable to deduce a plausible description of when ::reset is
          called.  It's practically unused in modules, too.
      cc47973e
    • Vladimír Čunát's avatar
      layer: rename knot_ identifiers that are private now · 4ad98bff
      Vladimír Čunát authored
      It causes lots of line changes, but it would be confusing to keep the
      current state over long term.
      4ad98bff
  18. Oct 11, 2016