DEBUG_IF accepts user-supplied function which decides which requests
should be logged.

Attempt to avoid duplicating ten lines in debug_logfinish_cb lead me
to splitting kr_log_qverbose_impl into two functions kr_log_q and kr_log_req.
This is another minor change to API exposed to modules.

Formerly both logs used slightly different formats and duplicated code.
From now on verbose log and request tracing are generated using the same
code.

This required a small change to request trace_log_f definition so it
might affect external modules.

Reported on Turris forums:
https://forum.turris.cz/t/dns-over-tcp-just-a-single-transaction/12003/21

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Source is
git+https://github.com/twbs/bootstrap.git@a78dc3aed640a35914361b837ce24573a0515e19#yeti/bootstrap.min.css
but our version has minor modifications:
- removed link to font file
- minor font and line height adjustments
- added SPDX header

Diffing minimized CSS file is a mess so use something like
$ awk '{gsub(/{|}|;/,"&\n"); print}'
to get something more legible.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Originally we used version 0.12.0 but the files in our repo did not
exactly match files in the upstream repo and I could not confirm
if the changes were meaningful or just artifact of source minimization
process.

To remove uncertainity I've updated selectize.js to latest upstream version
0.12.6, did not do any extra CSS minimization, and removed unused file
selectize.min.css.

As far as I can tell it seems to work.

Source:
git+https://github.com/selectize/selectize.js.git@eb0fca364f9bd6864ae197ea58c853f2717052a9

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

The SPDX file contains hand-written metadata about source URL, version,
authors, and license.

There are two missing pieces in HTTP module:
- bootswatch theme - I could not find what theme we ship, maybe it is
  based on one of bootswatch themes but heavily modified
- selectize.js source does not match respective files in upstream but
  contains minor changes

I will deal with these in later commits.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

These files did not have GNU GPL v3 boilderplate in them so
I've added machine readable tag with appropriate license.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Long GNU GPLv3 boilderplate was automatically replaced
with machine readable tag.

LFS isn't used since !912 (6d209ef9).

In finish() phase DONE is (almost?) always set, so it didn't make sense.
The mistake came from c16728f5 !678.

It was possible for some failures to disappear that way.

Credit goes to https://github.com/hasnat/knot-resolver-issue-66

Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

... to avoid shadowing which broke lint:other in CI.
And add NEWS entry.

Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

Well, the `view` note applies to any sockets passed from a supervisor,
but together that seems a very exotic combination.

These addresses have been deprecated for quite some time,
and this month they were even shut down.

Petr Špaček authored 5 years ago and Tomas Krizek committed 5 years ago

Reordered according to my intuition.

Petr Špaček authored 5 years ago and Tomas Krizek committed 5 years ago

Neither graphire nor Prometheus are useful without stats, and any data
they export needs explanation from stats module so it does not make
sense to separate them.