Grigorii Demidov authored 6 years ago and Vladimír Čunát committed 6 years ago

- answer_finalize: new layer
- kr_request: keep ::qsource.packet beyond the begin phase
- kr_request: add ::daemon_context

Vladimír Čunát authored 6 years ago and Petr Špaček committed 6 years ago

Thanks to Marek for noticing it.

Vladimír Čunát authored 6 years ago and Petr Špaček committed 6 years ago

It fired also when the name didn't contain the final dot.

Vladimír Čunát authored 6 years ago and Petr Špaček committed 6 years ago

We use it as relatively high-level function, often on user-input names,
so it seems suitable that it does convert the case.
This fixes cache.clear('Example.Org.'), and probably also negative trust
anchors and policy uses.

Vladimír Čunát authored 6 years ago and Tomas Krizek committed 6 years ago

- promote the part into a section
- move it right after the section about interactive CLI
- minor reformulations, location of the sockets, etc.
- fix location of the daemon-supervised anchor

daemon: TCP connection timeouting has changed; connection was closed after peer's inactivity before, now it is closed after incativity in both directions (peer->kresd, kresd->peer); prevents connection from closing before answer sent to client

Grigorii Demidov authored 6 years ago and Vladimír Čunát committed 6 years ago

Unificate handling of TCP timeouts for input and output connections; avoid redundant code; bugfixing

lint:clang-scan-build reported:
> warning: The code calls sizeof() on a pointer type.
> This can produce an unexpected result
but in our case it's intentional.
(Yes, using pointers as keys in trie isn't very pretty.)

Only count incoming requests into this,
as before "some simplifications" commit.

Grigorii Demidov authored 6 years ago and Vladimír Čunát committed 6 years ago

daemon/worker: avoid usage of qr_tasklist in struct request_ctx as it is redundant; use direct pointer to task instead

They don't seem to be useful individually, so why not clean up.

- Some (potentially) unused vars were left behind.
- The two on_* functions are identical except for the uv types passed,
  and those are surely the same in the part we use, but it's not worth
  to deduplicate when these functions are only two and so simple.
- lint:c was complaining about the uv_tcp_t malloc().

Also don't allocate much memory for cookies if we compile them out.

The support hasn't landed in libuv over all the years,
and we've been still reserving memory for it in advance.
Also comment on the singleton buffer usage.

I did NOT remove this one, as in a quick profile that would be
increase in roughly 0.5% time in malloc, so that's possibly justifiable.
(And this one is much less obstructing to splitting the worker code.)

See the message in parent commit.

A quick profiling showed no change in performance,
and in particular no change in time spent in malloc/free.
Some of the types in the union differed in size by a multiple.

If their performance won't be satisfying, replacements should be
considered first (e.g. jemalloc) before rolling our own stuff.