Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Their implementation was changed.
Fortunately I was able to find the message in Google's cache
and thus discover easily which one it is in the new archive.

The approach of the code was rather hacky, simulating some packets
arriving from upstream and making the module stack CONSUME that.
Instead we take a direct approach now: use the simplified validator API
and then insert into cache directly.

One effect is improved performance, and consequently roughly halving
the lag which happens when prefill module invokes this.
(With root zone the lag goes down to 0.1 s from over 0.2 s,
 on my relatively fast CPU.  Fortunately it's just once a day.)

Version 2.9 isn't supported anymore anyway, but 3.0.2 is needed for
extended error constants.

Josh Soref authored 3 years ago and Tomas Krizek committed 3 years ago

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The brackets notation and string quotation are not obvious to everyone.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Partly to document changes from recent changes,
partly to fix long-lasting issues in the descriptions.
Hopefully it will be easier to understand now.

Also improve a few details.

Use a single call as a setter and getter for log groups.

Refactor into more consistent lua API.

Using a single function to get/set values is more consistent with our
existing lua API rather than having two separate set and get functions.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

It's mainly in tests.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- add lua set_log_target() + docs
- default to 'stderr' (manual runs)
- switch to 'syslog' in distro-preconfig.lua
- a few minor tweaks

The purpose of this change is to make it harder to accidentally use the
legacy DoH implementation and free up the "doh" kind which may be used
as an alias to a modern implementation in the future.

To (hopefully) improve readability, rename the typical macro usage of:

    if (!kr_assume(x)) y; // to
    if (kr_fails_assert(x)) y;

As a convenience, replace the assert without a return value to a more
simple version:

    (void)!kr_assume(x);  // becomes
    kr_assert(x);

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Default 5 minutes (but off).
Randomize the delays +-25%.

This change already took place in !1082, this just updates the files to
correctly reflect the current situation.

Reported on:
https://gitter.im/CZ-NIC/knot-resolver?at=60213c720eed905f189da4d7

Arch Linux now ships knot-resolver in their repositories, delete
reference to AUR.

Thanks to daurnimator who adopted the package!

It's quite cheap for us, and it might help with dumb clients
overusing the lowest IP from each set.

Štěpán Balážik authored 5 years ago and Vladimír Čunát committed 4 years ago

Design discussion: #447
Code discussion: !1030

This slightly changes table_print() output format.
table_print() output is not intended for machine consumption,
use krprint.serialize_lua() or JSON for that purpose.

Output from table_print is now a valid Lua expression
if the input contains only serializable data types
(number, string, bool, nil, table), which is nice for copy&pasting.

Functions etc. are also pretty-printed but cannot be deserialized.
Numbers are pretty-printed as well so their precision is reduced (as
compared to krprint.serialize_lua).