modules/{http,watchdog}: fix stability problems

See merge request !1136

Vladimír Čunát authored 4 years ago and Tomas Krizek committed 4 years ago

As first noted in commit d1a229ae, in some cases we do call chains that
are not supported for JIT in LuaJIT.

I'm not 100% sure all of these are needed to comply, but the functions
here are really small and probably not to be that heavily used,
so I don't think it will be costly to interpret them
(and avoiding crashes is more important).

In my tests this fixed occasional crashes when using http://*/trace/*

adapt to knot 3.1 changes

See merge request !1134

ci: Sonarcloud fixup

See merge request !1135

ci: sonarcloud improvements

See merge request !1121

Vladimír Čunát authored 4 years ago and Tomas Krizek committed 4 years ago

and break the overlong line

policy.ANSWER: minor fixes, mainly around NODATA answers

See merge request !1129

Reported on:
https://gitter.im/CZ-NIC/knot-resolver?at=60213c720eed905f189da4d7

- return SOA in NODATA answers and allow customizing it
- only call ensure_answer() if really generating an answer
  (otherwise we might e.g. deplete XDP buffers, in extreme cases)

Arch Linux now ships knot-resolver in their repositories, delete
reference to AUR.

Thanks to daurnimator who adopted the package!

minor module docs fixes

See merge request !1131

Reported on:
https://gitter.im/CZ-NIC/knot-resolver?at=601ae90e9fa6765ef8f6b408

(and regularize indentation)  Reported on:
https://gitter.im/CZ-NIC/knot-resolver?at=601b36f6aa6a6f319d0235f5

In particular, non-support of EDNS is implied iff FORMERR without OPT
comes.  If OPT is there, one possibility is that there was something
wrong in the OPT that *we* sent, but it seems much more likely that
this particular server is just bad and we want to try another one.
https://tools.ietf.org/html/rfc6891#section-7
In particular, we would be in trouble if we dropped OPT in a zone
that is covered by DNSSEC.

It's now consistent with KNOT_RCODE_FORMERR and the official name
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-6

It wasn't really used for a long time and became completely obsolete after
!1030.

Rework iterate.c/selection.c error handling

Closes #640

See merge request !1126

This way leaves less room for mistakes, etc.  It's just the idea from:
dd0c99bd (comment 191580)

Previously this would pollute the RTT cache with non-sensical
measurements from unsuccessful TCP connects for example.

Module would crash due to the change of `request->upstream`
structure.

Previously the mitigation would stop some longer benign resolutions.
We can safely zero the subquery counter when choose a concrete transport
for the query (i.e. NS name with known IP address).

Lame delegations are weird, they breed more lame delegations on broken
zones since trying another server from the same set usualy doesn't help.
We force resolution of another NS name in hope of getting somewhere.

Previously a 12B reply with FORMERR would be treated as malformed
creating a need for a workaround (switching off EDNS for every malformed
answer).

Instead copy it from the request's options.

Reasoning: Minimization might have been turned off as a workaround for
broken authoritative servers which doesn't support it. There is no
reason to drop minimization when switching zones when following a CNAME.

When cancelling a query due to NSNXAttack mitigation when validator was
also in BOGUS state, records wouldn't be stripped from the answer.

These will become useful once we actually use it…

Previously there where resolve_badmsg and resolve_error functions used
to apply workarounds. This is now moved to selection.c and iterate.c
just provides feedback using the server selection API. Errors are now
handled centrally in selection.c:error.

ci lint:scan-build: work around changes in meson

See merge request !1127

In 1f7678ea meson was updated and that broke our scan-build.
Now we work around that.  Quick analysis of why:
https://github.com/mesonbuild/meson/pull/5918#issuecomment-762064902

dnstap tests: integrate into meson, CI, etc.

See merge request !1123