ci: packaging test for RockyLinux 8

See merge request !1187

add nix: apkg + CI

See merge request !1189

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

For now just a simple docker-based build, atop nixos-unstable
(for now my nixpkgs branch that also adds apkg itself).

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- Support is in apkg master now.
- The generated default.nix is exactly as in the distro:
  https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/dns/knot-resolver/default.nix
  (except for new version+hash, and one test needed a tweak since 5.3.2)

ci: test on armhf and arm64

See merge request !1186

Some tests (typically those using network) ocassionally fail due to
timeouts, which is probably due to increased CI load - perhaps reducing
it could make the tests more stable.

The test attempts to use the timestamp 2050-12-31T23:59:59, which can't
be represented with 32bit time_t due to Year 2038 problem.

Make sure we use the correct lemgth modifiers to support both 32b and
64b architectures.

ci: make the pkgbuild jobs re-use the archive (job)

See merge request !1188

The child pipelines behave a bit differently than expected,
in this respect.

policy.FLAGS: fix not applying properly in edge cases

See merge request !1179

Vladimír Čunát authored 3 years ago and Štěpán Balážik committed 3 years ago

The requests get traced even without verbose logging.
I expect it was a copy&paste mistake from QTRACE docs.

Vladimír Čunát authored 3 years ago and Štěpán Balážik committed 3 years ago

Perhaps this bug was now more pronounced since 5.3.0 changes.
Example problem was disabling minimization or 0x20 (globally or
for some problematic requests); without this change they would get
re-enabled during some fallback actions... which might be exactly
the wrong moment wrt. the motivation to setting these.
https://gitter.im/CZ-NIC/knot-resolver?at=60a221e86a950f3d46ed1cd9

lib/selection: be more careful with RO transactions

See merge request !1184

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

They probably couldn't hang open for long, as each client request
should cause some cache-searching and thus close it, and even with
queries stopping I haven't managed to find a case where it would be
left open but... it's nicer to clean up and it should be very cheap.

daemon/worker: fix a memory leak

See merge request !1182

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Discovered case: TCP write towards upstream fails due to ECONNRESET,
and on this place of code we "forget" the whole qr_task and thus its
corresponding kr_request, so it remains unanswered and using memory.

ci: allow failure of CentOS 8 packaging tests

See merge request !1185

Once again there's an issue with libuv-devel. Since the distro is EOL in
6 months, I'm not going to waste effort with investigating or fixing it.

meson: disable assertions

See merge request !1183

Make sure assertions are turned off - we use our own mechanism
(implemented in !1146), so this mostly affects foreign code, like Knot
DNS headers.

!1146 (comment 203044)

distro: add apkg support

See merge request !1178

rename kind="doh" to kind="doh_legacy"

See merge request knot/knot-resolver!1180

The purpose of this change is to make it harder to accidentally use the
legacy DoH implementation and free up the "doh" kind which may be used
as an alias to a modern implementation in the future.

lib/utils: define kr_require(), kr_assume() macros

Closes #495

See merge request knot/knot-resolver!1146

To (hopefully) improve readability, rename the typical macro usage of:

    if (!kr_assume(x)) y; // to
    if (kr_fails_assert(x)) y;

As a convenience, replace the assert without a return value to a more
simple version:

    (void)!kr_assume(x);  // becomes
    kr_assert(x);