Vicky Shrestha authored 7 years ago and Petr Špaček committed 6 years ago

There is no need to check for unique addr+port for FDs passed
by a supervisor process like systemd.

Vladimír Čunát authored 7 years ago and Petr Špaček committed 6 years ago

- clickable module references
- clickable RFC references via :rfc:`NNN#anchor`

Marek Vavruša authored 7 years ago and Grigorii Demidov committed 7 years ago

This was previously fixed in e25358d4,
but broken in the rewrite. The answer buffer size must be a maximum size,
otherwise payloads larger than configured UDP buffer size can't be
transmitted over TCP.

Logging handshake and connection failures should be verbose, as
it's not really a server failure if client errors, or uses a wrong
SPKI pin to the certificate. It is however not ideal to flood logs.

We use the knot style everywhere else; this was very similar and yet
different, so really annoying to me.  In the long term we might better
migrate to qp-tries from knot, but the API differs, so it's delayed...

It does almost nothing, currently.

Vladimír Čunát authored 7 years ago and Petr Špaček committed 7 years ago

Fields after kr_nsrep got offset; fortunately only new fields were
added in there, unused from lua so far.

Vladimír Čunát authored 7 years ago and Petr Špaček committed 7 years ago

Fixes https://gitlab.labs.nic.cz/knot/knot-resolver/issues/306

This changes more time than anticipated, as the old naming didn't apply
anymore (time of last cache clear).

It mostly worked, just by accident.
I see no use for negative initialization in this case.

Daniel Kahn Gillmor authored 7 years ago and Vladimír Čunát committed 7 years ago

"man man" says that the sections are:

       1   Executable programs or shell commands
       2   System calls (functions provided by the kernel)
       3   Library calls (functions within program libraries)
       4   Special files (usually found in /dev)
       5   File formats and conventions eg /etc/passwd
       6   Games
       7   Miscellaneous  (including  macro  packages  and  conventions), e.g.
           man(7), groff(7)
       8   System administration commands (usually only for root)
       9   Kernel routines [Non standard]

Since there is no command named kresd.system it does not belong in
section 8.

Section 7 includes conventions and useful patterns like gitcli(7),
which seems more similar to the documentation that is supplied in
kresd.systemd.

Tomas Krizek authored 7 years ago and Grigorii Demidov committed 7 years ago

When older gnutls version is used, make sure not to use undeclared
symbols or functions.

Decision function is separated out.

Some parts were hand-written, apparently.

In order to be able to spawn multiple processes with socket activation,
systemd template (see systemd.unit(5)) is used. This allows the user to
create any amount of instances by simply providing a unique name for
each of them. The most sensible instance identifiers are natural
numbers, but any convention could be used.

The default recommended service name becomes kresd@1.service, replacing
the older kresd.service. Sockets are renamed in a similar way. Users are
able to take advantage of bash expansion to spawn/control multiple
processes, e.g. "systemctl start kresd@{1..16}.service"

The socket-activated service can now be launched directly with
"systemctl start kresd@1.service", which will request the associated
sockets without the need for any extra priviledges or capabilities.

Stopping the kresd service now also stops the associated sockets.
Stopping any individual socket is an isolated opration now (stopping
kresd@1.socket no longer stop kresd-tls@1.socket and
kresd-control@1.socket).

Users and packagers are also encouraged to use drop-in files for extra
configuration or modifications to ensure compatibility with their
distribution.

Almost.  A trivial lib/layer/cache.c remains.
I put all lib/generic/*.h into libkres_HEADERS, to be sure.
They rarely change anyway.