Marek Vavruša authored 7 years ago and Vladimír Čunát committed 6 years ago

This updates the metatype to wrap knot_rrset_add_rdata and knot_rrset_init_empty
in a nicer way, and adds automatic GC destructor and tests.

Grigorii Demidov authored 6 years ago and Petr Špaček committed 6 years ago

fixup! 8ea37cc3 daemon/worker: robustness against the slow-lorris attack

Grigorii Demidov authored 6 years ago and Petr Špaček committed 6 years ago

This is an attempt to fix two problems:
1. kresd tries to close incoming TCP connection too early. This may lead
to multiple client reconnections. This problem primarily
affects TCP/TLS clients who send several queries over single TCP connection.

2. In certain circumstances outbound TCP connection doesn't timeout
despite that fact that upstream doesn't send back any answers.
This may lead to timeouts on non-problematic queries.

Anbang Wen authored 6 years ago and Petr Špaček committed 6 years ago

Since there is already a bundled JSON library, expose it to lua for
modules to use.

Grigorii Demidov authored 7 years ago and Petr Špaček committed 6 years ago

The old kr_rrkey() was used only on one place (and incorrectly) so now
we are replacing both copies with single implementation for general
resolver and root zone import.
It should not make any practical difference.

The problem here is when qr_task_send() returns an error, the
following error handler will attempt to cancel all tasks that were
started on the same connection, but that will only work for the first
task (which is finished), the qr_task_on_send() will have no effect
on tasks in progress as the passed handle is NULL, and the task->finished
is false, thus looping infinitely.

The solution here is to let the rest of the tasks complete, even though
sending answer back will fail (which is fine).

Vicky Shrestha authored 7 years ago and Petr Špaček committed 6 years ago

There is no need to check for unique addr+port for FDs passed
by a supervisor process like systemd.

Vladimír Čunát authored 6 years ago and Petr Špaček committed 6 years ago

- clickable module references
- clickable RFC references via :rfc:`NNN#anchor`

Marek Vavruša authored 7 years ago and Grigorii Demidov committed 7 years ago

This was previously fixed in e25358d4,
but broken in the rewrite. The answer buffer size must be a maximum size,
otherwise payloads larger than configured UDP buffer size can't be
transmitted over TCP.

Logging handshake and connection failures should be verbose, as
it's not really a server failure if client errors, or uses a wrong
SPKI pin to the certificate. It is however not ideal to flood logs.

We use the knot style everywhere else; this was very similar and yet
different, so really annoying to me.  In the long term we might better
migrate to qp-tries from knot, but the API differs, so it's delayed...

It does almost nothing, currently.

Vladimír Čunát authored 7 years ago and Petr Špaček committed 7 years ago

Fields after kr_nsrep got offset; fortunately only new fields were
added in there, unused from lua so far.