lua: use notice level for log() (!1208) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged lua: use notice level for log()

module-log into master

Merged Tomas Krizek requested to merge module-log into master 3 years ago

By default, notice level is set. Thus, if users want to use log() in the same way as pre-5.4, they'd have to increase the log level. This bumps the log level of log() function to keep the same behavior.

Activity

Tomas Krizek added bug label 3 years ago

added bug label
Tomas Krizek @tkrizek · 3 years ago

Author Owner

There are other ways to address the issue. I'm not 100% convinced that using notice for log() is the best way, but I don't see many downsides and it seems to be the simplest fix.
Vladimír Čunát added 2 commits 3 years ago
added 2 commits

39dd89db - lua: use notice level for log()

f1e026d2 - lib/log: check the *last* log group number

Compare with previous version
Vladimír Čunát mentioned in commit 71c594f4 3 years ago

mentioned in commit 71c594f4
Vladimír Čunát merged 3 years ago

merged
Vladimír Čunát mentioned in commit d2b5596c 3 years ago

mentioned in commit d2b5596c
Vladimír Čunát mentioned in merge request !1223 (merged) 3 years ago

mentioned in merge request !1223 (merged)
Vladimír Čunát mentioned in commit 0cdfc5c6 3 years ago

mentioned in commit 0cdfc5c6

Please register or sign in to reply