Skip to content
Snippets Groups Projects

lib: additional dname checks

Merged Grigorii Demidov requested to merge dname-checks into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I really like this :heart: it feels much less error-prone. I can't see any downside to the approach.

  • Well, we're slightly "schizophrenic" now, as some places still use the pattern auto_free char *n_str = kr_dname_text(n); (which uses malloc), but I don't think this "inconsistency" is a real problem. We can do something about these later, e.g. migrate all to these new macros as well.

  • Well, "later" might easily turn into "never". Why not convert everything now? How much work is it?

  • Petr Špaček
  • Vladimír Čunát added 11 commits

    added 11 commits

    • fa6d641b...62ef37fc - 10 commits from branch master
    • 957358d2 - treewide: additional dname checks

    Compare with previous version

  • Vladimír Čunát resolved all discussions

    resolved all discussions

  • Vladimír Čunát enabled an automatic merge when the pipeline for 957358d2 succeeds

    enabled an automatic merge when the pipeline for 957358d2 succeeds

  • mentioned in commit febd08ce

  • Please register or sign in to reply
    Loading