daemon: avoid memory leak when reading broken incoming TCP stream (!626) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged Grigorii Demidov requested to merge various-tcp-fixes into master 6 years ago

Leak scenario:

client establishes TCP connection
sends valid query
sends valid query prefixed by wrong length (less then length of DNS query)
leak

Edited 6 years ago by Petr Špaček

Approved by

Activity

Grigorii Demidov changed the description 6 years ago

changed the description
Petr Špaček changed title from daemon: broken incoming TCP stream can lead to memory leaks in some circumstances, fixed to daemon: avoid memory leak when reading broken incoming TCP stream 6 years ago

changed title from daemon: broken incoming TCP stream can lead to memory leaks in some circumstances, fixed to daemon: avoid memory leak when reading broken incoming TCP stream
Petr Špaček added bug label 6 years ago

added bug label
Petr Špaček added 5 commits 6 years ago
added 5 commits

8baa3a3c...a861c4de - 4 commits from branch master

d9b9c2d4 - daemon: broken incoming TCP stream can lead to memory leaks in some circumstances, fixed

Compare with previous version
Petr Špaček changed the description 6 years ago

changed the description
Petr Špaček enabled an automatic merge when the pipeline for d9b9c2d4 succeeds 6 years ago

enabled an automatic merge when the pipeline for d9b9c2d4 succeeds
Petr Špaček merged 6 years ago

merged
Petr Špaček mentioned in commit df546afb 6 years ago

mentioned in commit df546afb
Petr Špaček @pspacek · 6 years ago

Contributor

/cc @vavrusam

Please register or sign in to reply