send EDNS with SERVFAILs, e.g. on validation failures (!827) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged Vladimír Čunát requested to merge opt-in-bogus into master 5 years ago

All threads resolved!

Fixes https://gitlab.labs.nic.cz/knot/knot-resolver/issues/180. Extracted out of !794 (closed) and !660 (closed).

Large pipeline seems good: https://gitlab.labs.nic.cz/knot/knot-resolver/pipelines/49582 (earlier version: https://gitlab.labs.nic.cz/knot/knot-resolver/pipelines/49365)

Possible caveats: modules that want to produce a SERVFAIL will need to clear to_wire flags on RRs that shouldn't go into the answer (which depends on what the module wants to achieve). That's probably hard to avoid, as e.g. in case of CNAME chains we should use non-empty SERVFAILs anyway (but that will be fixed in !660 (closed) or similar).

Edited 5 years ago by Vladimír Čunát

Activity

Vladimír Čunát marked as a Work In Progress 5 years ago

marked as a Work In Progress
Vladimír Čunát changed the description 5 years ago

changed the description
Vladimír Čunát added 17 commits 5 years ago
added 17 commits

081c1398...6e3d9531 - 13 commits from branch master

e8275038 - treewide nitpick: more sensitive detection of KR_STATE_FAIL

0b62fe3c - lib/resolve: don't skip EDNS if failed

65131f93 - don't set TC if omitting an ADDITIONAL record

bd16c26d - lib/resolve: failing states in answer finalization

Compare with previous version
Toggle commit list
Vladimír Čunát added 1 commit 5 years ago
added 1 commit

068b8570 - lib/resolve nitpick: fix lint after the parent commit

Compare with previous version
Vladimír Čunát unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
Vladimír Čunát changed the description 5 years ago

changed the description
Petr Špaček @pspacek started a thread on an outdated change in commit 068b8570 5 years ago

Resolved 5 years ago by Vladimír Čunát
Last reply by Petr Špaček 5 years ago

Petr Špaček @pspacek · 5 years ago

Contributor

It works for me, it can be merged once the comment is clarified.

Petr Špaček assigned to @vcunat 5 years ago

assigned to @vcunat

Vladimír Čunát added 11 commits 5 years ago

added 11 commits

068b8570...63e6913b - 6 commits from branch master
84bca55a - treewide nitpick: more sensitive detection of KR_STATE_FAIL
13afe21f - lib/resolve: don't skip EDNS if failed
5128d54c - don't set TC if omitting an ADDITIONAL record
f41473b1 - lib/resolve: failing states in answer finalization
71461d79 - lib/resolve nitpick: fix lint after the parent commit

Compare with previous version

Toggle commit list

Vladimír Čunát added 5 commits 5 years ago

added 5 commits

ee7eadee - treewide nitpick: more sensitive detection of KR_STATE_FAIL
83b8ba1d - lib/resolve: don't skip EDNS if failed
746044fe - don't set TC if omitting an ADDITIONAL record
c5654da7 - lib/resolve: failing states in answer finalization
98efda10 - lib/resolve nitpick: fix lint after the parent commit

Compare with previous version

Toggle commit list

Vladimír Čunát resolved all discussions 5 years ago

resolved all discussions

Vladimír Čunát mentioned in commit 5 years ago

mentioned in commit 625f4882

Vladimír Čunát merged 5 years ago

merged

Please register or sign in to reply