Karel Koci authored 2 years ago and Simon Borek committed 2 years ago

The syntax used in the Bash scripts here requires at minimum Bash 5.0.
This checks for it and reports reasonable error message instead of
failure.

There are two discovered issues with older versions of bash.

The first issue is the change of empty array expansion in Bash 4.4
resulted in empty arrays not being considered as undefined anymore. We
depended on this heavily and thus we can't easily go bellow that
version.

The second issue is that syntax `[[ -v "foo[key]" ]` works only in Bash
5.0 and newer. This checks if specific key is in the associative array.
The replacement could be `[ "${foo[key]:+_}" ]` in some cases but this
only works if value is also nonempty. Thus it makes sense to just the
more clear and reliable syntax and such depend on Bash 5.0.

This character should not have been there.

This should be used always when we apply patches as otherwise git tries
to do rebase on pull and if that passes then we try to reapply all
patches which fails. The cleanup simply nukes the original git history
thus we prevent these issues.

Karel Koci authored 4 years ago and Karel Koci committed 3 years ago

There are two changes in this commit. First most noticable is removal of
all updater lists.

The second but more significant change is pretty much reformat of all
generate scripts. It extracts common git and configuration handling from
compile_pkgs to generate_common.
The advantage of this is of course code sharing but also that other
generate scripts now get features such as local git mirror.

This is just stylistic change. It removes dirname and instead relies on
string operation. There should be no way of having in $0 anything else
other than some valid path. That is last part has to be at least
/name_of_file. This means that we do not have to rely on dirname and we
can safely just remove anything after last slash (including that slash).
We user dirname only for paths in sub-directories.

The default value of output_path should have been set after arguments
parsing as empty variable is used to detect if variable was provided or
not.

Also change help as OUTPUT_PATH is optional and there is default in
place if not provided.

This can be shared between multiple scripts so move it to centralized
file.

This reverts commit 1bd0f379.

This was created to migrate Turris OS 4.0-alpha* releases. The first
supported version 4.0-beta1 already contains correct path with board
specific path so there is no need to preserve these obsolete ones.
Non the less they are also wrong with additional introduced changes.
They point to pkglists in invalid location.

This requires also removal of code on build server to not use --obsolete
option and to not deploy those.

This reverts commit 1bd0f379.

This was created to migrate Turris OS 4.0-alpha* releases. The first
supported version 4.0-beta1 already contains correct path with board
specific path so there is no need to preserve these obsolete ones.
Non the less they are also wrong with additional introduced changes.
They point to pkglists in invalid location.

This requires also removal of code on build server to not use --obsolete
option and to not deploy those.

This should help us to debug system configuration better to see what
exactly was targeted version. This also helps users to see what they are
dealing with. It in some sense informs them if they are upgrading to new
version or if that is just packages change (because of configuration
change) in same release.

This should help us to debug system configuration better to see what
exactly was targeted version. This also helps users to see what they are
dealing with. It in some sense informs them if they are upgrading to new
version or if that is just packages change (because of configuration
change) in same release.

These are temporally lists to redirect previous versions of updater to
correct locations.

These are temporally lists to redirect previous versions of updater to
correct locations.

This creates lists that can be included in to each other. This is done
by hack that original script calling one of these lists passes base URI
to access sources and that is later reused. This is how relative URI
should work in future but it is not completed now so we can overcome it
this way and have almost same support.

This also means that we no longer have to specify target branch for
lists because it no longer matters.

Fallback branch is for now dropped because we are not doing small build
at the moment. We should in future return to them but they will be
implemented differently then fallback branch is.

This also does some base list cleanup.

This is better idea as having #!/bin/bash -e is fragile. Anyone can run
this script with bash -x file and that way unintentionally disable -e
flag.