Karel Koci authored 5 years ago and Karel Koci committed 5 years ago

We have problem of chicken and egg. To know if we can update we need to
update updater but doing so we have to start updating system. The
problem is that reverting to 3.x with new updater would be pretty hacky
and is also not something we want. The common problem is that users
install some packages with opkg and those are added to updater's
/etc/updater/conf.d/opkg-auto.lua file. Updater is stuck when such
package is no longer provided. Modifying given file is not ideal because
user can have other files that are not automatically managed and running
replacement scripts on them is not good idea. Instead it is better to
ensure that update proceeds even if there is a request for package that
is no longer in repository.

This commit adds two types of rules for packages that are not in Turris
OS 4.0 compared to Turris OS 3.x.
Fist rule is to convince updater that package exists but is effectively
empty. That is done by marking package as virtual:
    Package("NAME", { virtual = true })
Other rule is that package is somewhat replaced by some other package
and we add temporally provide for missing package in to it:
    Package("EXISTING", { provides = {"NAME"} })

This should push problems with requests for non-existing packages to
last step of migration, that is after removal of tos3to4 package.

The list I worked on here was generated only for Omnia. Turris 1.x
should be almost same and mostly just subset so this should be enough.
First I downloaded all repositories indexes from 3.11.9 and from 4.0.1.

    cd 3x
    for repo in base hardware lucics management node openwisp packages php printing routing sidn telephony turrispackages; do curl https://repo.turris.cz/omnia/packages/$repo/Packages > $repo; done
    cd ../4x
    for repo in base core luci openwisp packages routing sidn telephony turrispackages; do curl https://repo.turris.cz/hbs/omnia/packages/$repo/Packages > $repo; done

Next step was to collect all package names.

    cd ../3x
    for repo in $(ls); do sed -n 's/Package: \(.*\)/\1/p' $repo; done | sort > ../3s
    cd ../4x
    for repo in $(ls); do sed -n 's/Package: \(.*\)/\1/p' $repo; done | sort > ../4s

And lastly diff was made for packages missing in 4s but present in 3s:

    cd ..
    diff --new-line-format="" --unchanged-line-format="" 3s 4s

This fixes problem with preferences in feeds and removes patch required
to prevent such collision.

My patch, which was present in the hack folder, is no longer applying as
mariadb was updated in OpenWrt 18.06, 19.07 and master branches.
This patch was meant to be a workaround as something in OpenWrt was
changed and it caused inconsistency in the installation of packages and we
would like to have provided mariadb in our feed, this was the easiest
and a quicker solution at that time.

Solution is provided in this commit: a42ef21a740653ee76146bfccee1ab6afbd65539

Add directories and files generated byt generate_lists and
generate_medkit.

The default value of output_path should have been set after arguments
parsing as empty variable is used to detect if variable was provided or
not.

Also change help as OUTPUT_PATH is optional and there is default in
place if not provided.

This was missed in previous commit cd222783

The empty `space` variable in Makefile for hostapd was causing that
invalid Kconfig was generated and configuration phase failed.

This is happening only with latest GNUMake.

This can be shared between multiple scripts so move it to centralized
file.

libubox introduced new function that is now missing for ucert.

Downgrading ucert is not ideal because it contains security fix.

The real problem might be in procd and update of libubox just exposes
that. There is newer version of procd.