Skip to content
Snippets Groups Projects

Draft: patches/openwrt: tweak leds setup patch for Omnia

Merged Karel Koci requested to merge bugfix/invalid-phy into hbl
2 unresolved threads

First change is that the LEDs should have been configured in leds configuration file not in network one. This moves it there.

Second and most important change is the change from list of WiFi devices to just plain wlan list for three wlan devices. This is in no way ideal as it relies on initialization of PCI devices in order. This means that leds won't no longer reflect exactly the position in PCI slot but rather order of initialization. The issue we are trying to solve here is that original code just wasn't working as WiFi devices are not initialized at time of this script execution. The result was that WiFi leds just were not configured at all, at least till the system update that caused re-execution of this script later in system execution.

And the last change is the move of this patch from branding to to-upstream. We can't push it right now but we should be able in the future once upstream updates kernel to version with our RGB leds support.

Merge request reports

Pipeline #87314 passed

Pipeline passed for b3da9cb7 on bugfix/invalid-phy

Merged by Karel KociKarel Koci 3 years ago (Aug 27, 2021 11:33am UTC)

Merge details

  • Changes merged into hbl with b3da9cb7 (commits were squashed).
  • Deleted the source branch.

Pipeline #87440 failed

Pipeline failed for b3da9cb7 on hbl

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply