Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S supervisor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • TurrisTurris
  • updater
  • supervisor
  • Merge requests
  • !26

Draft: notify: Do not send full stacktrace in notification

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Martin Matějek requested to merge fix/34-updater-throws-stacktrace-instead-of-updatingerrors into master Aug 17, 2022
  • Overview 13
  • Commits 4
  • Changes 2

Supervisor just passes the updater error message without really knowing what went wrong, just that something unexpected happened.

This workaround is more or less hack to silence overly verbose trace from Lua code. Instead of passing the full stacktrace, try to find line with error message.

Basically look for following pattern:

  msg = string: "\
<ERROR MESSAGE HERE>"

Perhaps the root cause would be better handled in updater Lua code, because updater has more context of what went wrong.

Closes: #34 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/34-updater-throws-stacktrace-instead-of-updatingerrors