Vladimír Čunát authored 1 year ago and Aleš Mrázek committed 1 year ago

When I see "configuration" it sounds more like a complete file,
but we only give bits of it that need adding other parts.

Vladimír Čunát authored 1 year ago and Aleš Mrázek committed 1 year ago

The different addresses don't need to share an interface.
Also provide more details on what fails.

Vladimír Čunát authored 1 year ago and Aleš Mrázek committed 1 year ago

outdated views schema, different IP value, etc.

Old legacy. The generated .texi sources cause a huge number of warnings
that we do not have a good way of fixing, and lately it stopped working
completely, without giving us any explanation as to what the problem is
(just exit code 1 and no *error* message).

The former setup would cause subsequent runs of `poetry install` to
alternate between the `poethepoet` versions. Instead, we just want to
separate them for Python before 3.8 and Python from 3.8 onwards.

This commit renames `docs:public` to `pages` as required by GitLab CI to
recognize Pages jobs correctly. It also adds the `public` directory into
`artifacts:paths`.

key.len was shorter by (the current) rsp_len, which was confusing/wrong.

Discovered by triggering:
 assertion "i < key.len && i < key_leq.len" failed in kr_view_select_action

Everywhere else we order `nodata` parameter before `ttl`.
Let's make it consistent to reduce potential for confusion.

It's perhaps the main use case for 'redirect' to also define address(es)
for the apex.  An empty zone with address(es) in apex also makes sense.

Aleš Mrázek authored 1 year ago and Vladimír Čunát committed 1 year ago

ttl, nodata and tags are configurable for hostname and address(es) pairs

Direct usage without the hints module seems better.

It was a bit wide, with 5s and 3h, and distinction between
these two "groups" of rules was a bit random wrt. TTL choice.
Now: 5m for user's rules and 1h for RFC-default rules.

I found it relatively hard to choose defaults, but at least for
user-supplied rules it's trivial to configure a different default.

Otherwise we'd let confusing things pass all validations.

Also refactor the C APIs, causing most of the diffs.

Sometimes it is useful to access a global variable from lua.

At least the normal non-root hints.
We needed extended API for this functionality, and C API is simpler
for this, thanks to LuaJIT FFI.

However, this required moving code from the separate module.
The moved code is not changed in any way in this commit.
I considered it bad to keep such core code outside the main daemon+lib,
as it's not big.  Now LuaJIT FFI forced me to clean this up.

This works better in the current case when master branch with the most
recent 5.7.0 tag got merged into the 6.0 branch.  In that case we do not
want the most recent *generally* reachable tag, and git-describe has
probably good logic for this (using first-parent jumps I guess).

This leverages Environments on GitLab to expose different versions of
Knot Resolver docs. The `docs:build` job builds the documentation and
exposes it via job artifacts. Then `docs:develop` (for branches) and
`docs:release` (for tags) take these artifacts and expose them via an
Environment link (an example of this in action may be seen at
[https://gitlab.nic.cz/ostava/knot-resolver/-/environments]).

There is also an optional, manually runnable `docs:public` job, which,
when run, propagates the documentation to the main GitLab Pages of the
project (e.g. [https://knot.pages.nic.cz/knot-resolver]) - this will
probably be mostly used for the latest release, although this setup
pretty much allows us to swap it for whatever version we like at any
time.