Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

- written relatively defensively - act OK even if the API
  isn't used in an ideal way
- CI lint:scan-build: bump the error count;
  It's only another instance of the mis-detected array_push().
- the removed stale note in modules/meson.build isn't really related

iterate: fix limit on CNAME chain length

See merge request !899

Unbound has limit 10, and practically useful numbers are way lower.

The accounting was just broken and overly messy anyway.

performance: lua-related improvements

See merge request !874

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

Basically the same as the parent commit (just much simpler).

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

When all lua modules get unloaded, this change makes the module's
contribution to QPS unmeasurable (for me), saving a few percent.
The point is to almost always return very cheaply, in particular without
creating any lua GC object (like FFI for kr_query).

Note: some checks didn't make much sense, so I improved those as well.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

Running the full special-domain checks is relatively expensive.

I've never seen anyone use postrules.

The new way of transitioning to layer callbacks - done because of
portability (mainly to aarch64) - is a bit expensive.  This is a simple
way of recovering that cost.  Merge 603a24fc regressed speed a bit.

Packaging fixes

See merge request !895

The Group= settings was ommited and default group of User= was
implicitly used. Now the group set at build time is respected.

GC didn't respect the user/group set at build time at all.

Previously, it was possible to update just "knot-resolver" even
when the "knot-resolver-module-http" package was installed, or the
other way around.

ci: increase test timeout

See merge request !897

During heavy load, test:valgrind tends to fail quite often with timeout.
This should improve the situation.

tests: packaging

See merge request !892

Lukas Jezek authored 5 years ago and Petr Špaček committed 5 years ago

Directory with subdirectory "packaging" is called "component".

List all components: python3 tests/packaging-doc.py --list
Run all tests/compoments: python3 tests/packaging-doc.py
Run specific test/component: python3 tests/packaging-doc.py --test <component>

The file structure for 1 component:
	daemon - dependencies for 1 component "kresd daemon" (default component, must always be there)
	scripts/distros - dependencies for 1 component for specific distro (must always be there)
	scripts/dockerfile_gen.py - test Dockerfile generator, see below
	tests/packaging.py - script to generate and build all combinations
	                     of Docker files for all components
	[component] - directory of component/test, see below
		      (e.g. "client/packaging/", "modules/http/packaging/" etc.)

The file structure of each component:
[component]
	<distro>/<version> - package names
		- builddeps - list of build depedencies
		- rundeps - list of runtime depedencies
		- pre-build.sh - script called before build phase
		- post-build.sh - script called after build phase
		- pre-run.sh - script called before run phase
		- post-run.sh - script called after run phase
		- install.sh and build.sh script called during build phase
	test.config or test.sh - kresd config test or shell script
note: content of "scripts/distroos" is same as "<distro>/<version>" of component.

There are "build" and "run" phases. "build" phase precedes "run" phase.
All script are called in this order:
	1. pre-<phase>.sh
	2. install packages specifed in the file "<phase>deps"
	3a. for "build" phase: run build.sh and install.sh
	3b. for "run" phase: run 'kresd -c [component]/test.config' or config.sh
	4. remove packages specified in the file "<phase>deps"
	5. post-<phase>.sh

Each step above is combines base components with a component under test.
E.g. component "scripts/distros" always precedes component "daemon/packaging"
and it precedes the tested component e.g. "modules/http".

In long term we might migrate this to py.test or some other well known
framework.

DoH debugging: auxiliary library for OpenSSL key logging

See merge request !886

opensslkey_debug is never built for opensuse, because
openssl is not a dependency, thus there's no need to remove
the non-existent file.

Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

It would be cumbersome to explicitly cast all those void*
to correct function types.

Petr Špaček authored 5 years ago and Tomas Krizek committed 5 years ago

Wireshark 3.0.5 is able to deal with # comments in middle of log file.

Petr Špaček authored 5 years ago and Tomas Krizek committed 5 years ago

It is not used in any way by default, enabling it requires manual
LD_PRELOAD= trickery as described in the source file.