Fixes #167.

The output is only better if built with libknot >= 2.4.0.
As a side-effect, add lua method knot_rrset_t::txt_dump;
it's a light wrapper around knot_rrset_txt_dump.

Re-tested rolling with a.moot-servers.net, to be sure.

The format of TA store is compatible both ways with old kresd.
Note: it requires the parent commit to work, i.e. new libzscanner.

Comment parsing will only be supported in future libzscanner version.
Also move out of the module, as trust_anchors.lua requires it and isn't
in a module.

engine_cmd() doesn't print the error() exceptions thrown from lua;
it only leaves the message on lua stack.

- Remove abstraction of the refresh callback, as we always use the same
  function.  This way the code is significantly easier to understand.
- Add a couple more comments.

It was strange to keep it indefinitely, and the code was already
half-prepared for this change.  Theoretically, if a resolver has been
stopped for too long to miss a key's period of Revoked status, it would
continue to trust the key forever.

- printing refresh time in milliseconds could've been confusing;
- move syntactic sugar definitions close to the rest of the table;

... via trust_anchors.{bootstrap_url,bootstrap_ca}

- docs: fix cache.current_* since long ago d5272b4b
- don't allow "cache.foo = 'bar'" for abitrary foo
- restore cache['nic.cz'] after b31bad2ccf while not breaking completion
- #cache won't work on lua 5.1, so remove it

Vladimír Čunát authored 8 years ago and Štěpán Balážik committed 8 years ago

That will allow us to discover the top-level symbols for completion.
For others we can e.g.: for n in pairs(net) do print(n); end
I must admit I fail to understand some of the related lua magic.

I believe it was unused, so no risk was caused, but better remove it.
There's the complication that its signature has changed since libknot-2.4.0.
Fixes https://gitlab.labs.nic.cz/knot/resolver/issues/146

These shouldn't make any problems:
- the verbose messages don't print any scope, and
- reputation cache doesn't consider scope.

Vladimír Čunát authored 8 years ago and Ondřej Surý committed 8 years ago

On standard 64-bit: 24 -> 16 bytes per element.

Vladimír Čunát authored 8 years ago and Ondřej Surý committed 8 years ago

Motivation: maintaining these by hand in kres.lua is tricky, as just
inserting or reordering the structures can do anything and isn't
detected in general.  For example, `rr_array_t::at` has always
"missed a star".

A couple libknot structure fields have apparently changed name since
the old definitions were written; in most cases I renamed them in *.lua.

The file daemon/lua/kres-gen.lua will be regenerated only if explicitly
deleted.  That requires building with debug symbols and gdb on $PATH.

Fixes https://github.com/CZ-NIC/knot-resolver/issues/35.

Some structures have changed but lua was still using the old ABI.
I think no our lua code used the fields misplaced due to this,
except an example in documentation.

I didn't check much of the ABI in there.  I wish I knew some
(half-)automatic way how to do that.