Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Probably, it seems "more consistent".
Some defines still don't have it, but I left those.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- const for names of log groups
- enum kr_log_group for a single log group
- the kr_log_groups bitmap doesn't need to be exposed or even exported
- return bool instead of int

Now those type definitions can be simply loaded without any error, e.g.
luajit daemon/lua/kres-gen.lua
That will be useful for checking them without regenerating them.

To (hopefully) improve readability, rename the typical macro usage of:

    if (!kr_assume(x)) y; // to
    if (kr_fails_assert(x)) y;

As a convenience, replace the assert without a return value to a more
simple version:

    (void)!kr_assume(x);  // becomes
    kr_assert(x);

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Default 5 minutes (but off).
Randomize the delays +-25%.

- add lua options debugging.assumption_abort and
  debugging.assumption_fork to make the behaviour configurable
- select default values based on meson buildtype:
  - debug/debugoptimized (default, e.g. used in CI) - abort and don't
    fork
  - plain/release - don't abort, but fork if abort is user-configured

Add HTTP headers to an optional kr_request.qsource.headers structure.
Headers are stored as name, value string pairs.

The following snippet can be used to access the headers in lua modules:

```
if (req.qsource.headers ~= nil) then
	for i = 1, tonumber(req.qsource.headers.len) do
		local name = ffi.string(req.qsource.headers.at[i - 1].name)
		local value = ffi.string(req.qsource.headers.at[i - 1].value)
		print(name, value)
	end
end
```

Fixes #616

Štěpán Balážik authored 5 years ago and Vladimír Čunát committed 4 years ago

Design discussion: #447
Code discussion: !1030

Logging strings: I originally wanted to have four chars inside [],
but it doesn't really matter in these cases where logs don't happen
within a request, so "[xdp]" won due to uniformity and simplicity.

FIXME: see FIXMEs in diff, document the API change, re-review.

Vladimír Čunát authored 4 years ago and Petr Špaček committed 4 years ago

See the definition of kr_cdb_pt for details.

Vladimír Čunát authored 4 years ago and Petr Špaček committed 4 years ago

... in case of usage from kresd (GC does it a bit differently).

It is very useful when debugging. This code gets executed only with
special DEBUG policy so we do not need to worry about maximum performance.

In particular this gets rid of last light user data inside kresd.

It was still causing problems on some systems, for example Debian Sid.
The error was the same: "bad light userdata pointer" from luajit,
but note that the problem can still be triggered by lua libraries,
e.g. cqueues.

Now it works again with the latest gdb-9.1.
As a side effect, some simplification was possible, so that some
typedefs are newly defined at once with the underlying type.

This new approach uses per-request variables in Lua and creates new
callback for each DEBUG_IF call instead of each request.

Attempt to avoid duplicating ten lines in debug_logfinish_cb lead me
to splitting kr_log_qverbose_impl into two functions kr_log_q and kr_log_req.
This is another minor change to API exposed to modules.

Formerly both logs used slightly different formats and duplicated code.
From now on verbose log and request tracing are generated using the same
code.

This required a small change to request trace_log_f definition so it
might affect external modules.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

These files did not have GNU GPL v3 boilderplate in them so
I've added machine readable tag with appropriate license.

Vladimír Čunát authored 5 years ago and Tomas Krizek committed 5 years ago

- written relatively defensively - act OK even if the API
  isn't used in an ideal way
- CI lint:scan-build: bump the error count;
  It's only another instance of the mis-detected array_push().
- the removed stale note in modules/meson.build isn't really related

The new way of transitioning to layer callbacks - done because of
portability (mainly to aarch64) - is a bit expensive.  This is a simple
way of recovering that cost.  Merge 603a24fc regressed speed a bit.

Somehow I didn't notice this field when adding ::add_selected.
We probably never put anything into answer's ADDITIONAL,
so noone's noticed a problem until now.

Also the log now uses the same format query UID format as elsewhere.

... without light userdata and yet it should be efficient.
Also with checkout layer, but I have no nice way of testing that one.

...when making calls from lua to C modules; use luaJIT FFI instead.
This eliminates some cases of lua_pushlightuserdata().

This will allow modules like view etc. work in the same way with packets
received over HTTP.