It wasn't really used for a long time and became completely obsolete after
!1030.

Previously there where resolve_badmsg and resolve_error functions used
to apply workarounds. This is now moved to selection.c and iterate.c
just provides feedback using the server selection API. Errors are now
handled centrally in selection.c:error.

Štěpán Balážik authored 5 years ago and Vladimír Čunát committed 4 years ago

Design discussion: #447
Code discussion: !1030

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Finally it does not rely on ordering in the answer.
Stringification seemed like an easy hack for tests, let's see how it
works in the long term.

In English, the final letter is doubled when a word of two or more
syllables has stress on the final syllable so a correct form is
"occurred".

LuaJIT FFI was using opendir() (etc.) variants with 32-bit inodes
but the C parts was using them as 64-bit inode variants.
Consequently the `struct dirent` layout didn't match and we were getting
filenames shifted by eight bytes.

Now the whole dir-listing lua function is written in C.

Logging strings: I originally wanted to have four chars inside [],
but it doesn't really matter in these cases where logs don't happen
within a request, so "[xdp]" won due to uniformity and simplicity.

All strings should be properly escaped but some non-escaped versions
were leaking into error messages.

Functions like trust_anchors.summary() return strings including tabs and
newlines, so we do not escape those for human-readable output.

This change allows sandbox to pretty-print return values from functions
which return multiple values, e.g. future net.bufsize() from MR !1026.

This slightly changes table_print() output format.
table_print() output is not intended for machine consumption,
use krprint.serialize_lua() or JSON for that purpose.

Output from table_print is now a valid Lua expression
if the input contains only serializable data types
(number, string, bool, nil, table), which is nice for copy&pasting.

Functions etc. are also pretty-printed but cannot be deserialized.
Numbers are pretty-printed as well so their precision is reduced (as
compared to krprint.serialize_lua).

Code was copied from Lua sandbox, the old copy is to be removed once new
pretty-printer is finished.

At the moment it does not handle functions and other non-serializable
types.

Side-effect is that keys are grouped by their type, so numbers come
first and strings later..

Error handling inside the test was incorrent and a detected error would
blow up the test routine.

Related: !1011, 3f5a826d

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Three instances send commands and DNS queries to each other.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Control protocol uses \n as command delimiter so we cannot allow \n
inside commands. Users should be able to Lua-escape \n with \010.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

For now we still attempt to support systems without lua-cqueues,
e.g. Ubuntu 16.04.

lua-http depends on lua-cqueues so the test for availability of lua-http
at the beginning of kr_https_fetch() should cover lua-cqueues as well.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

We were exceeding CI time limit while running config tests under
Valgrind so let's see if smaller number of tests will get us through CI.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

map() command on leader instance now:
- detects call errors on followers
- detects unsupported number of return values
- detects unsupported data types which cannot be serialized
- keeps nil return values (signaled by table counter "n")

Fixes: #662

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Let's detect syntax errors before sending the command to all instances.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Helper functions for handling variable length arrays with nil values.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Reasons:
- It allows to run several kresd instances and use map() without
  worrying about instance parameters.
- It removes special case from map().

Proper functionality depends on changes in MR !1011.

Petr Špaček authored 4 years ago and Tomas Krizek committed 4 years ago

Serializes: boolean, nil, number, string, table.
Skips all other types (functions, cdata, thread ...) and repeated
references to tables.

Resulting string should Lua-evaluate to identical objects.

Lukas Jezek authored 4 years ago and Tomas Krizek committed 4 years ago

This change allows map() to work with systemd integration.

As a bonus the new client implementation is based on Lua cqueues
allows caller to wrap map() in worker.corroutine() and get
asynchronous execution/avoid blocking main loop.

Currently socket communication does not employ timeouts so a hang
instance will lead to hang map() call. This does not affect query
processing _if_ map() is being run in worker.corroutine.

Fixes: #554
Fixes: #620