Add a utility function for simpler lua API when setting extended errors.

Version 2.9 isn't supported anymore anyway, but 3.0.2 is needed for
extended error constants.

Credit for code goes to Vladimír Čunát

Tomas Krizek authored 3 years ago and Vladimír Čunát committed 3 years ago

Answers to EDNS requests from certain lua policies that use the
answer_clear() function would lack OPT RR and thus violate the MUST
condition in RFC6891.6.1.1.

Josh Soref authored 3 years ago and Tomas Krizek committed 3 years ago

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

sandbox.lua:72: attempt to call global 'log_notice' (a nil value)
Broken by commit 39dd89db (MR !1208)

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

NSEC* params were not being stashed by this function.  For prefilling
it's useful, but doing it on *every* NSEC* record would be quite a waste,
so we introduce a parameter to select this.

Implementation: there were good reasons not to implement this until
needed - it wasn't straightforward at all.

Tomas Krizek authored 3 years ago and Vladimír Čunát committed 3 years ago

By default, notice level is set. Thus, if users want to use log() in the
same way as pre-5.4, they'd have to increase the log level. This bumps
the log level of log() function to keep the same behavior.

It's not a perfect solution and with the future policy engine it will
hopefully be better, but it's really trivial to add this already.
(should've done that years ago)

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

It's special: always on and not shown in log_groups() output.

It's been quite a long fight to find how to best deal with such
a special case (from user perspective; code itself is easy).

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The result gets logged as a single multi-line message,
so let's not repeat any prefix on (some of) those in-the-middle lines.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Systemd docs say:
> Those arguments must contain valid journal entries including
> the variable name, e.g. "CODE_FILE=src/foo.c", [...]

I tried that passing all three strings empty (without variable name)
wouldn't result into the line getting logged; the suggested style does.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

The former "default" dumping style isn't really used anywhere in Knot.
The only visible difference is that RRSIGs are now logged *without*
replacing their TTLs by the original non-decremented TTL values.
That can avoid some confusion when reading debug logs.
(Those original TTLs are still shown a bit further on each line.)

This is all that's missing in comparison to enum knot_rr_type.
For now I didn't remove types that aren't present there (anymore),
even though noone would miss them, most likely.

I considered switching it to our usual 3-option combo,
but that way didn't really seem useful.

I didn't intend to use this mix of tabs and spaces for indentation.

- we've been using lua's formatting so far, so avoid changing that
- some lua values would be harder to format with the C style

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Let's be consistent witk kr_log_name2level()
and even generally we tend to use negative numbers for errors.

Use a single call as a setter and getter for log groups.

Refactor into more consistent lua API.

Using a single function to get/set values is more consistent with our
existing lua API rather than having two separate set and get functions.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- add lua set_log_target() + docs
- default to 'stderr' (manual runs)
- switch to 'syslog' in distro-preconfig.lua
- a few minor tweaks

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Probably, it seems "more consistent".
Some defines still don't have it, but I left those.

Lukas Jezek authored 3 years ago and Tomas Krizek committed 3 years ago

logging

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- unify interactive mode to stdout
- use its own logging group
- elevated log level when the command throws an exception
- don't try detecting that the logs go back into the same console
  (yes, in that case you can see some lines twice)
- don't make the binary mode turn off logging

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

- const for names of log groups
- enum kr_log_group for a single log group
- the kr_log_groups bitmap doesn't need to be exposed or even exported
- return bool instead of int

It's better to use separate log group, to separate between logs that
come from the lua module vs native C implementation. It is also more
descriptive, since http modules is used for other stuff besides its
deprecated DoH.

Plural makes more sense to me here, since it can take a table with
multiple entries as input.

Besides testing the API, running this test also ensures all log groups
have been properly defined (as long as kr_assertions are turned on).